Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow admin to sync package only #434

Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat: allow admin to sync package only #434

merged 3 commits into from
Apr 6, 2023

Conversation

hezhengxu2018
Copy link
Collaborator

@hezhengxu2018 hezhengxu2018 commented Apr 4, 2023 •
edited by fengmk2
Loading

closes #412

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #434 (8c5b79b) into master (eedfb2b) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   97.27%   97.09%   -0.18%     
==========================================
  Files         156      156              
  Lines       13997    14008      +11     
  Branches     1796     1793       -3     
==========================================
- Hits        13615    13601      -14     
- Misses        382      407      +25
Impacted Files Coverage Δ
app/common/constants.ts 100.00% <100.00%> (ø)
app/port/controller/AbstractController.ts 98.87% <100.00%> (+<0.01%) ⬆️
app/port/controller/PackageSyncController.ts 100.00% <100.00%> (ø)
app/port/schedule/CheckRecentlyUpdatedPackages.ts 100.00% <100.00%> (ø)
app/port/schedule/SyncPackageWorker.ts 92.85% <100.00%> (+0.12%) ⬆️
config/config.default.ts 88.29% <100.00%> (-7.96%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 changed the title feat:sync mode admin feat: sync mode admin Apr 6, 2023
@fengmk2 fengmk2 added the enhancement New feature or request label Apr 6, 2023
@fengmk2 fengmk2 changed the title feat: sync mode admin feat: allow admin to sync package only Apr 6, 2023
@fengmk2 fengmk2 mentioned this pull request Apr 6, 2023
Closed
@fengmk2 fengmk2 merged commit c5ac715 into cnpm:master Apr 6, 2023
fengmk2 pushed a commit that referenced this pull request Apr 6, 2023
@semantic-release-bot
Release 3.12.0
570d346 
[skip ci]

## [3.12.0](v3.11.2...v3.12.0) (2023-04-06)

### Features

* allow admin to sync package only ([#434](#434)) ([c5ac715](c5ac715)), closes [#412](#412)
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hezhengxu2018 hezhengxu2018 deleted the feat/sync-mode-admin branch April 11, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

考虑将syncMode的权限进行拆分实现更细颗粒的控制？
2 participants
@hezhengxu2018 @fengmk2