Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create sync task with auth header #442

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

hezhengxu2018
Copy link
Collaborator

@hezhengxu2018 hezhengxu2018 commented Apr 17, 2023

The upstream repository carries authentication header information via task parameters when alwaysAuth is enabled


上游仓库开启alwaysAuth时通过任务参数携带认证头信息

@fengmk2 fengmk2 changed the title feat:create task with auth header feat: create task with auth header Apr 17, 2023
app/port/typebox.ts Outdated Show resolved Hide resolved
@hezhengxu2018 hezhengxu2018 marked this pull request as draft April 18, 2023 01:50
@hezhengxu2018
Copy link
Collaborator Author

看了一下只有PackageSyncerService里用到了NPMRegistry,只要保证里面调用的地方都带上auth参数就行

@hezhengxu2018 hezhengxu2018 marked this pull request as ready for review April 18, 2023 03:13
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #442 (76a84e0) into master (a64c90b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   97.16%   97.11%   -0.06%     
==========================================
  Files         157      157              
  Lines       14123    14154      +31     
  Branches     1810     1817       +7     
==========================================
+ Hits        13722    13745      +23     
- Misses        401      409       +8     
Impacted Files Coverage Δ
app/common/FileUtil.ts 100.00% <100.00%> (ø)
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
app/core/entity/Task.ts 100.00% <100.00%> (ø)
app/core/service/BinarySyncerService.ts 94.19% <100.00%> (ø)
app/core/service/PackageSyncerService.ts 98.31% <100.00%> (+<0.01%) ⬆️
app/port/controller/PackageSyncController.ts 100.00% <100.00%> (+1.39%) ⬆️
app/port/typebox.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 changed the title feat: create task with auth header feat: create sync task with auth header Apr 18, 2023
@fengmk2 fengmk2 added the enhancement New feature or request label Apr 21, 2023
@fengmk2 fengmk2 merged commit d95c58b into cnpm:master Apr 21, 2023
fengmk2 pushed a commit that referenced this pull request Apr 21, 2023
[skip ci]

## [3.15.0](v3.14.0...v3.15.0) (2023-04-21)

### Features

* create sync task with auth header ([#442](#442)) ([d95c58b](d95c58b))
@github-actions
Copy link

🎉 This PR is included in version 3.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hezhengxu2018 added a commit to hezhengxu2018/cnpmcore that referenced this pull request Apr 21, 2023
The upstream repository carries authentication header information via
task parameters when alwaysAuth is enabled

---

上游仓库开启 alwaysAuth 时通过任务参数携带认证头信息
hezhengxu2018 pushed a commit to hezhengxu2018/cnpmcore that referenced this pull request Apr 21, 2023
[skip ci]

## [3.15.0](cnpm/cnpmcore@v3.14.0...v3.15.0) (2023-04-21)

### Features

* create sync task with auth header ([cnpm#442](cnpm#442)) ([d95c58b](cnpm@d95c58b))
@hezhengxu2018 hezhengxu2018 deleted the feat-task-with-auth-header branch April 26, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants