Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync chrome-for-testing binary #455

Merged
merged 2 commits into from
May 5, 2023
Merged

feat: sync chrome-for-testing binary #455

merged 2 commits into from
May 5, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented May 4, 2023

puppeteer/puppeteer#10131 Puppeteer has updated the default browser to Chrome and added the corresponding implementation as follows:

  1. 🧶 Added a new category /-/binary/ for Chrome , exp: /-/binary/chrome-for-testing/113.0.5672.63/mac-arm64/chrome-mac-arm64.zip
  2. 🤖 Replaced the implementation of original chromium version.
  3. ♻️ No longer synchronized the Chromium binary files from past versions of Puppeteer.

puppeteer/puppeteer#10131 puppeteer 更新了默认浏览器为 chrome,新增对应实现

  1. 🧶 /-/binary/ 新增 chrome binary 分类, 示例链接/-/binary/chrome-for-testing/113.0.5672.63/mac-arm64/chrome-mac-arm64.zip
  2. 🤖 替换原 puppeteer 中 chromium 对应实现
  3. ♻️ 不再同步 puppeteer 历史版本中的 chromium 二进制文件

@elrrrrrrr elrrrrrrr added the enhancement New feature or request label May 4, 2023
@elrrrrrrr elrrrrrrr requested a review from fengmk2 May 4, 2023 08:37
@elrrrrrrr elrrrrrrr changed the title feat: puppeteer chrome WIP: feat: puppeteer chrome May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #455 (27199fb) into master (f891aed) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   97.44%   97.36%   -0.08%     
==========================================
  Files         159      160       +1     
  Lines       14652    14780     +128     
  Branches     1875     2034     +159     
==========================================
+ Hits        14277    14390     +113     
- Misses        375      390      +15     
Impacted Files Coverage Δ
...pp/common/adapter/binary/ChromeForTestingBinary.ts 100.00% <100.00%> (ø)
app/common/enum/Binary.ts 100.00% <100.00%> (ø)
config/binaries.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@fengmk2 fengmk2 linked an issue May 4, 2023 that may be closed by this pull request
@elrrrrrrr elrrrrrrr changed the title WIP: feat: puppeteer chrome feat: sync chrome-for-testing binary May 4, 2023
@elrrrrrrr elrrrrrrr requested a review from fengmk2 May 4, 2023 13:12
@fengmk2 fengmk2 merged commit dd7d73e into master May 5, 2023
@fengmk2 fengmk2 deleted the puppeteer-chrome branch May 5, 2023 08:10
fengmk2 pushed a commit that referenced this pull request May 5, 2023
[skip ci]

## [3.18.0](v3.17.1...v3.18.0) (2023-05-05)

### Features

* sync chrome-for-testing binary ([#455](#455)) ([dd7d73e](dd7d73e))
@fengmk2
Copy link
Member

fengmk2 commented May 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mirror "chrome-for-testing"
2 participants