fix: ignore non-file on tar entry filter #458

fengmk2 · 2023-05-05T17:01:29Z

ENOENT: no such file or directory, stat '/root/.cnpmcore/downloads/2023/05/06/unpkg_@iov_wallet-providers@1.0.0_0f152162-9cce-4a80-bacc-41271b7aac3f/package'

app/common/FileUtil.ts

app/core/service/PackageVersionFileService.ts

test/common/FileUtil.test.ts

fengmk2 · 2023-05-05T17:02:01Z

app/common/FileUtil.ts

@@ -110,6 +110,7 @@ const WHITE_FILENAME_CONTENT_TYPES = {
 export function mimeLookup(filepath: string) {
  const filename = path.basename(filepath).toLowerCase();
  if (filename.endsWith('.ts')) return PLAIN_TEXT;
+  if (filename.endsWith('.lock')) return PLAIN_TEXT;


https://unpkg.com/browse/@gitpod/ide-metrics-api-grpc@0.0.1-main-gha.8962/pkg-yarn.lock

codecov · 2023-05-05T17:07:33Z

Codecov Report

Merging #458 (969f126) into master (90d5046) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 969f126 differs from pull request most recent head e2687fc. Consider uploading reports for the commit e2687fc to get more accurate results

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   97.56%   97.50%   -0.06%     
==========================================
  Files         166      166              
  Lines       15372    15377       +5     
  Branches     2002     2000       -2     
==========================================
- Hits        14997    14993       -4     
- Misses        375      384       +9

Impacted Files	Coverage Δ
app/common/FileUtil.ts	`100.00% <100.00%> (ø)`
app/core/service/PackageVersionFileService.ts	`97.22% <100.00%> (+0.07%)`	⬆️

... and 2 files with indirect coverage changes

fengmk2 · 2023-05-05T17:09:21Z

https://unpkg.com/browse/noa-live2dapi@1.0.8/model/kp31/kp31_/destroy/%E6%9B%BF%E6%8D%A2%E9%85%8D%E7%BD%AE/model.json

竟然还有中文路径。。。

  sql: "SELECT * FROM `package_version_files` WHERE `package_version_id` = '645537672967dbdbc623eb3c' AND `directory` = '/model/kp31/kp31_/destroy/替换配置' AND `name` = 'model.json' LIMIT 1"

2023-05-06 01:05:54,247 WARN 1104822 [-/127.0.0.1/12246f90-eb67-11ed-9638-3ba850b69082/10558.541ms GET /] [PackageVersionFileService.syncPackageVersionFiles:error] packageVersionId: 645537672967dbdbc623eb3c, 1182 paths, tmpdir: /root/.cnpmcore/downloads/2023/05/06/unpkg_noa-live2dapi@1.0.8_b3395061-e620-4d61-b552-feb882af124a, error: Error: ER_CANT_AGGREGATE_2COLLATIONS: Illegal mix of collations (ascii_general_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '='

sql/1.15.0.sql

app/core/service/PackageVersionFileService.ts

test/port/controller/PackageVersionFileController/raw.test.ts

fengmk2 · 2023-05-05T17:45:38Z

app/core/service/PackageVersionFileService.ts

@@ -105,7 +107,9 @@ export class PackageVersionFileService extends AbstractService {
    if (file) return file;
    const stat = await fs.stat(localFile);
    const distIntegrity = await calculateIntegrity(localFile);
-    const dist = pkg.createPackageVersionFile(path, pkgVersion.version, {
+    // make sure dist.path store to ascii, e.g. '/resource/ToOneFromχ.js' => '/resource/ToOneFrom%CF%87.js'
+    const distPath = encodeURIComponent(path).replace(/%2F/g, '/');


需要做一下判断，超出 ascii 编码范围的才需要进行 encodeURIComponent

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURI

[skip ci] ## [3.19.2](v3.19.1...v3.19.2) (2023-05-05) ### Bug Fixes * ignore non-file on tar entry filter ([#458](#458)) ([7e63e7f](7e63e7f))

github-actions · 2023-05-05T17:55:20Z

🎉 This PR is included in version 3.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

fix: ignore non-file on tar entry filter

7e3bd4a