fix: use nfs download api #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fengmk2
commented
May 6, 2023
| @@ -34,6 +38,8 @@ export interface NFSClient { | |||
|
|
|||
| createDownloadStream(key: string): Promise<Readable | undefined>; | |||
|
|
|||
| download(key: string, filepath: string, options: DownloadOptions): Promise<void>; | |||
There was a problem hiding this comment.
@elrrrrrrr 需要使用 download 接口，stream 模式在 cnpmjs.org 服务器卡住了。文件没有下载完，大小都是一个。
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 97.46% 97.47%
=======================================
Files 166 166
Lines 15407 15428 +21
Branches 1994 1996 +2
=======================================
+ Hits 15017 15038 +21
Misses 390 390
|
fengmk2
pushed a commit
that referenced
this pull request
May 6, 2023
[skip ci] ## [3.20.1](v3.20.0...v3.20.1) (2023-05-06) ### Bug Fixes * use nfs download api ([#461](#461)) ([bb16957](bb16957))
|
🎉 This PR is included in version 3.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
会引入一个不兼容的变更，需要 nfsClient 实现 download 方法 🤔 |
第一个版本的 nfsClient 规范就有 download 方法约定的 https://github.com/cnpm/cnpmjs.org/wiki/NFS-Guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.