Skip to content

Commit 4084102

Browse files
committed
fix: Standardize parameter naming and enhance documentation across multiple files
1 parent d016614 commit 4084102

File tree

8 files changed

+21
-16
lines changed

8 files changed

+21
-16
lines changed

internal/app/app.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ var UpdaterModule = fx.Module("updater",
102102
),
103103
fx.Invoke(func(lc fx.Lifecycle, us updater.Service, logger log.Logger) {
104104
lc.Append(fx.Hook{
105-
OnStart: func(ctx context.Context) error {
105+
OnStart: func(_ctx context.Context) error {
106106
logger.Info().Msg("Registering Updater Service start hook")
107-
us.Start(ctx)
107+
us.Start(_ctx)
108108
return nil
109109
},
110-
OnStop: func(ctx context.Context) error {
110+
OnStop: func(_ctx context.Context) error {
111111
logger.Info().Msg("Registering Updater Service stop hook")
112112
us.Stop()
113113
return nil

internal/backend/database/database.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ CREATE TABLE IF NOT EXISTS tools (
5353
CREATE INDEX IF NOT EXISTS idx_tools_server_id ON tools(source_server_id);
5454
`
5555

56+
// DB is the database implementation of the DBInterface.
57+
// It handles SQL operations for the agent-browser data persistence.
5658
type DB struct {
5759
*sql.DB
5860
// logger log.Logger // Optional: Inject logger if DB methods need logging

internal/backend/models/models.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Package models defines the data structures used by the agent-browser application.
2+
// It includes entity definitions for MCP servers, tools, and related data types.
13
package models
24

35
import "time"

internal/config/exporter_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@ func (m *mockBackend) ListMCPServers() ([]models.MCPServer, error) {
3434
}
3535

3636
//nolint:unused
37-
func (m *mockBackend) AddMCPServer(name, url string) (*models.MCPServer, error) {
37+
func (m *mockBackend) AddMCPServer(_name, _url string) (*models.MCPServer, error) {
3838
return nil, errors.New("not implemented in mock")
3939
}
4040

4141
//nolint:unused
42-
func (m *mockBackend) RemoveMCPServer(id int64) error {
42+
func (m *mockBackend) RemoveMCPServer(_id int64) error {
4343
return errors.New("not implemented in mock")
4444
}
4545

4646
//nolint:unused
47-
func (m *mockBackend) GetMCPServer(id int64) (*models.MCPServer, error) {
47+
func (m *mockBackend) GetMCPServer(_id int64) (*models.MCPServer, error) {
4848
return nil, errors.New("not implemented in mock")
4949
}
5050

5151
//nolint:unused
52-
func (m *mockBackend) ProcessFetchedTools(serverID int64, fetchedTools []models.FetchedTool) (added, updated int, err error) {
52+
func (m *mockBackend) ProcessFetchedTools(_serverID int64, _fetchedTools []models.FetchedTool) (added, updated int, err error) {
5353
return 0, 0, errors.New("not implemented in mock")
5454
}
5555

5656
//nolint:unused
57-
func (m *mockBackend) UpdateMCPServerStatus(id int64, checkErr error) {
57+
func (m *mockBackend) UpdateMCPServerStatus(_id int64, _checkErr error) {
5858
// No-op in mock
5959
}
6060

internal/events/events.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Package events provides an event bus implementation for internal application events.
2+
// It defines event types and structures for communication between components.
13
package events
24

35
import (

internal/updater/service_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,24 +108,24 @@ func (m *mockBackendService) UpdateMCPServerStatus(id int64, checkErr error) {
108108
// Add unused methods to satisfy interface
109109
//
110110
//nolint:unused
111-
func (m *mockBackendService) AddMCPServer(name, url string) (*models.MCPServer, error) {
111+
func (m *mockBackendService) AddMCPServer(_name, _url string) (*models.MCPServer, error) {
112112
panic("unused")
113113
}
114114

115115
//nolint:unused
116-
func (m *mockBackendService) RemoveMCPServer(id int64) error { panic("unused") }
116+
func (m *mockBackendService) RemoveMCPServer(_id int64) error { panic("unused") }
117117

118118
//nolint:unused
119-
func (m *mockBackendService) GetMCPServer(id int64) (*models.MCPServer, error) { panic("unused") }
119+
func (m *mockBackendService) GetMCPServer(_id int64) (*models.MCPServer, error) { panic("unused") }
120120

121121
// Helper to get recorded status update
122122
//
123123
//nolint:unused
124-
func (m *mockBackendService) getLastStatusUpdate(id int64) (error, bool) {
124+
func (m *mockBackendService) getLastStatusUpdate(id int64) (bool, error) {
125125
m.mu.Lock()
126126
defer m.mu.Unlock()
127127
err, ok := m.statusUpdates[id]
128-
return err, ok
128+
return ok, err
129129
}
130130

131131
// Helper to get recorded processed tools

internal/web/handlers/api.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,6 @@ func (h *APIHandlers) ListTools(w http.ResponseWriter, r *http.Request) {
301301
// Get all tools - not implemented yet
302302
h.logger.Info().Msg("Listing all tools is not yet implemented")
303303
http.Error(w, "Listing all tools is not implemented yet", http.StatusNotImplemented)
304-
return
305304
}
306305

307306
// RediscoverTools handles POST /api/mcp/rediscover-tools

internal/web/handlers/api_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,12 @@ func (m *mockBackendServiceForAPI) GetMCPServer(id int64) (*models.MCPServer, er
117117
// --- Unused Service Methods (Panic if called) ---
118118

119119
//nolint:unused
120-
func (m *mockBackendServiceForAPI) ProcessFetchedTools(serverID int64, fetchedTools []models.FetchedTool) (int, int, error) {
120+
func (m *mockBackendServiceForAPI) ProcessFetchedTools(_serverID int64, _fetchedTools []models.FetchedTool) (int, int, error) {
121121
panic("ProcessFetchedTools not implemented/needed for API tests")
122122
}
123123

124124
//nolint:unused
125-
func (m *mockBackendServiceForAPI) UpdateMCPServerStatus(id int64, checkErr error) {
125+
func (m *mockBackendServiceForAPI) UpdateMCPServerStatus(_id int64, _checkErr error) {
126126
panic("UpdateMCPServerStatus not implemented/needed for API tests")
127127
}
128128

0 commit comments

Comments
 (0)