Skip to content

Commit 9984698

Browse files
committed
fix: Address CI and linter issues
Corrects Go version mismatch, GitHub Actions permissions, and Go linting errors reported by MegaLinter. - Bumps Go version in `go.yaml` workflow to 1.24, aligning with `go.mod`. - Sets default `permissions: read-all` in `go.yaml` and `release.yaml` workflows to resolve Checkov warnings. - Adds missing package comments to satisfy `revive` linter across multiple internal packages.
1 parent 710a6ba commit 9984698

File tree

17 files changed

+37
-15
lines changed

17 files changed

+37
-15
lines changed

.github/workflows/go.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,23 @@ on:
77
pull_request:
88
branches: [main]
99

10+
# Define default permissions as read-only
11+
permissions: read-all
12+
1013
jobs:
1114
build:
1215
name: Build & Test
1316
runs-on: ubuntu-latest
17+
env:
18+
GOPRIVATE: github.com/co-browser/agent-browser
1419
steps:
1520
- name: Check out code
1621
uses: actions/checkout@v4
1722

1823
- name: Set up Go
1924
uses: actions/setup-go@v5
2025
with:
21-
go-version: '1.21' # Or your desired Go version
26+
go-version: '1.24'
2227

2328
- name: Setup tools
2429
run: make setup

.github/workflows/release.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
branches:
77
- main
88

9+
# Define default permissions as read-only
10+
permissions: read-all
11+
912
jobs:
1013
release:
1114
runs-on: ubuntu-latest

internal/app/app.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Package app provides the core application setup using Fx.
12
package app
23

34
import (
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
// Package database provides types and functions for database interactions.
12
package database

internal/backend/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
// Package backend provides backend service implementations.
12
package backend

internal/config/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
// Package config handles application configuration loading and access.
12
package config

internal/log/fx_adapter.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Package log provides an adapter for Fx logging using zerolog.
12
package log
23

34
import (

internal/log/log.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Package log provides logging utilities and Fx integration.
12
package log
23

34
import (

internal/mcp/client/client.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
// Package client implements the MCP client logic.
12
package client

internal/mcp/protocol/protocol.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
// Package protocol defines the MCP protocol structures and constants.
12
package protocol

0 commit comments

Comments
 (0)