Skip to content

Commit cac217f

Browse files
committed
fix: linting
1 parent 03ebb2a commit cac217f

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

internal/web/handlers/api.go

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,9 @@ func (h *APIHandlers) AddMCPServer(w http.ResponseWriter, r *http.Request) {
195195
h.logger.Error().Err(err).Msg("Failed to parse form data")
196196
w.WriteHeader(http.StatusBadRequest)
197197
// Use components package directly
198-
components.AddServerErrorFeedback("Form parse error").Render(r.Context(), w)
198+
if renderErr := components.AddServerErrorFeedback("Form parse error").Render(r.Context(), w); renderErr != nil {
199+
h.logger.Error().Err(renderErr).Msg("Failed to render error feedback component")
200+
}
199201
return
200202
}
201203

@@ -205,7 +207,9 @@ func (h *APIHandlers) AddMCPServer(w http.ResponseWriter, r *http.Request) {
205207
if name == "" || url == "" {
206208
w.WriteHeader(http.StatusBadRequest)
207209
// Use components package directly
208-
components.AddServerErrorFeedback("Missing name or url").Render(r.Context(), w)
210+
if renderErr := components.AddServerErrorFeedback("Missing name or url").Render(r.Context(), w); renderErr != nil {
211+
h.logger.Error().Err(renderErr).Msg("Failed to render error feedback component")
212+
}
209213
return
210214
}
211215

@@ -220,7 +224,9 @@ func (h *APIHandlers) AddMCPServer(w http.ResponseWriter, r *http.Request) {
220224
}
221225
w.WriteHeader(statusCode)
222226
// Use components package directly
223-
components.AddServerErrorFeedback(errorMsg).Render(r.Context(), w)
227+
if renderErr := components.AddServerErrorFeedback(errorMsg).Render(r.Context(), w); renderErr != nil {
228+
h.logger.Error().Err(renderErr).Msg("Failed to render error feedback component")
229+
}
224230
return
225231
}
226232

@@ -229,7 +235,10 @@ func (h *APIHandlers) AddMCPServer(w http.ResponseWriter, r *http.Request) {
229235
// Send HX-Trigger to reset form after successful request (Optional - requires JS listener)
230236
// w.Header().Set("HX-Trigger", "resetAddForm")
231237
// Use components package directly
232-
components.AddServerSuccessFeedback(server.Name).Render(r.Context(), w)
238+
// Also check error on success feedback rendering
239+
if renderErr := components.AddServerSuccessFeedback(server.Name).Render(r.Context(), w); renderErr != nil {
240+
h.logger.Error().Err(renderErr).Msg("Failed to render success feedback component")
241+
}
233242
// SSE refresh will handle list update separately
234243
}
235244

@@ -254,15 +263,19 @@ func (h *APIHandlers) ListMCPServersFragment(w http.ResponseWriter, r *http.Requ
254263
if err != nil {
255264
h.logger.Error().Err(err).Msg("Error listing MCP servers for fragment")
256265
w.WriteHeader(http.StatusInternalServerError)
257-
// Use components package directly for error feedback
258-
components.AddServerErrorFeedback("Failed to load server list").Render(r.Context(), w)
266+
// Use components package directly for error feedback, and check error
267+
if renderErr := components.AddServerErrorFeedback("Failed to load server list").Render(r.Context(), w); renderErr != nil {
268+
h.logger.Error().Err(renderErr).Msg("Failed to render error feedback in list fragment")
269+
}
259270
return
260271
}
261272

262273
// Set content type to HTML
263274
w.Header().Set("Content-Type", "text/html; charset=utf-8")
264-
// Render the list body component directly using parent templates package
265-
templates.ServerListBodyComponent(servers).Render(r.Context(), w)
275+
// Render the list body component directly using parent templates package, and check error
276+
if renderErr := templates.ServerListBodyComponent(servers).Render(r.Context(), w); renderErr != nil {
277+
h.logger.Error().Err(renderErr).Msg("Failed to render server list body component")
278+
}
266279
}
267280

268281
// GetMCPServer handles GET /api/mcp/servers/:id

0 commit comments

Comments
 (0)