Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xunit.any_date and xunit.any_datetime to_date argument shouldn't be evaluated at creation time #32

Open
drtyrsa opened this issue Jun 2, 2012 · 1 comment

Comments

@drtyrsa
Copy link

drtyrsa commented Jun 2, 2012

This

def any_date(from_date=date(1990, 1, 1), to_date=date.today()):

is not a very good idea. If the code runs for a lot of time, to_date won't be changing. At it makes documentation misleading:

django_any.xunit.any_date(from_date=datetime.date(1990, 1, 1), to_date=datetime.date(2012, 5, 3))

Seems like a strange default choice for to_date. :-)

@drtyrsa
Copy link
Author

drtyrsa commented Jun 2, 2012

Pull request #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant