Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in error reporting #1332

Open
mister-drgn opened this issue Dec 24, 2024 · 4 comments
Open

Possible regression in error reporting #1332

mister-drgn opened this issue Dec 24, 2024 · 4 comments

Comments

@mister-drgn
Copy link

mister-drgn commented Dec 24, 2024

I am installing sbcl and coalton with nix, and editing with Lem. Using nixpkgs' latest version of coalton (20241012) and sbcl 2.4.7, I'm seeing what looks like a regression in error reporting. With an older version of coalton/sbcl, I get the following behavior:

Using Lem

  1. Start slime
  2. evaluate (cl-user::load (sb-ext:posix-getenv "ASDF"))
  3. evaluate (asdf:load-system 'coalton)
  4. compile-and-load a file that has a coalton-toplevel in it

A minimal example would be:

(defpackage #:my-package
  (:use 
   #:coalton 
   #:coalton-prelude))

(in-package #:my-package)

(named-readtables:in-readtable coalton:coalton)

(coalton-toplevel
  (define x (+ 1 "2")))

When I compile, I get an error, as expected. The number "1" is underlined in red, and when I move the cursor to to it, the error message pops up. This is the desired behavior.

Now, when I do the same with the current version of coalton and sbcl in nixpkgs (the versions given above), I don't see anything underlined. If I move the cursor to the end of the coalton-toplevel form, I see the same error message.

Thanks.

EDIT: I'm been working on figuring out the versions of coalton where error reporting does and does not work, based on what nix is installing. Here's what I've worked out:
Old version (error reporting works): coalton revision 05111b8 from June 6, 2024
New version (error reporting fails): quicklisp repo version 20241012-git

@stylewarning
Copy link
Member

CC @jbouwman

@Jason94
Copy link

Jason94 commented Dec 24, 2024

I'm seeing similar behavior in VSCode using the Alive plugin for Common Lisp. I'm getting an error underline under coalton-toplevel on the most recent version of Coalton.
compile_1
compile_2

@mister-drgn
Copy link
Author

mister-drgn commented Dec 24, 2024

I'm seeing similar behavior in VSCode using the Alive plugin for Common Lisp. I'm getting an error underline under coalton-toplevel on the most recent version of Coalton.

compile_1

compile_2

Did you get better behavior in the past? I had the same experience with vs code, even with the coalton version that has working error reporting on Lem. That was one of the reasons I tried Lem.

@Jason94
Copy link

Jason94 commented Dec 25, 2024

Aah, that's true. I checked out the revision you listed as giving the correct behavior, and in VSCode it still looks exactly like I posted above. Nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants