Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Release Candidate #5

Open
coatless opened this issue Jan 26, 2018 · 3 comments
Open

CRAN Release Candidate #5

coatless opened this issue Jan 26, 2018 · 3 comments

Comments

@coatless
Copy link
Collaborator

@daviddalpiaz Next weekend I'm shooting to release this to CRAN. I think a release build will have solved:

Alternatively, we can hold off until #1 resolves the ability to provide custom chunks. I'm thinking along the lines of:

add_option(tag, rendered_file)

So, maybe something like:

doc_chunk_options() %>% 
    add_option("solution", "soln") %>%
    add_option("directions", c("soln", "assign"))

Thoughts?

@daviddalpiaz
Copy link
Contributor

I think as long as the solution = TRUE is being removed from the solution Rmd, it's fine to release. The customization can come in a later release.

@coatless
Copy link
Collaborator Author

coatless commented Feb 6, 2018

@daviddalpiaz

I think we'll roll two releases:

  1. Present build state
  2. Build state post exclusion of the solution = TRUE flag

@coatless
Copy link
Collaborator Author

coatless commented Feb 7, 2018

Rolled the present build as a GH-only release.

I'll modify a few things over the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants