Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Acid test for liquid compatibility #396

Open
epage opened this issue Mar 16, 2020 · 1 comment
Open

Create Acid test for liquid compatibility #396

epage opened this issue Mar 16, 2020 · 1 comment
Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid

Comments

@epage
Copy link
Member

epage commented Mar 16, 2020

The liquid test suite has helped us identify a lot of gaps in our compatibility but it is very incomplete still.

Ideas

  • Create common input for liquid-rust and liquid-ruby and verify outputs
  • Easy to test variety of corner cases (e.g. nil, empty, and blank or unexpected data types)
@epage epage added enhancement Improve the expected std-compatibility Jekyll flavor of liquid labels Mar 16, 2020
@epage epage changed the title Create ACID test for liquid compatibility Create Acid test for liquid compatibility Mar 16, 2020
@epage
Copy link
Member Author

epage commented Mar 16, 2020

One tricky thing will be to separate implementation concepts, bugs in liquid-ruby, and bugs in liquid-rust.

For example {{ 5.size }} in the Ruby implementation returns how many bytes 5 takes up in-memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage