Fix: infinite loop on empty record #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #34 +/- ##
==========================================
Coverage ? 92.85%
==========================================
Files ? 2
Lines ? 98
Branches ? 11
==========================================
Hits ? 91
Misses ? 7
Partials ? 0 Continue to review full report at Codecov.
|
simenandre
approved these changes
Apr 10, 2021
runeh
approved these changes
Apr 10, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2021
# [2.0.0-alpha.4](v2.0.0-alpha.3...v2.0.0-alpha.4) (2021-04-10) ### Bug Fixes * infinite loop on empty record ([#34](#34)) ([5596de4](5596de4))
|
🎉 This PR is included in version 2.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that caused the generator to go into an infinite loop when trying to generate empty record runtype.
Fixes #33, more details there.
I think the problem was caused by
writeRecordTypenot writing anything at all if the record had no fields, sincegroupFieldKindswill correctly return and empty array if you pass it an empty array.