kv,server: replace PerReplicaClient RPC client with adapter

gRPC and DRPC clients have different signatures. To unify them, a common
interface was created for both types of clients, and replaced the gRPC
and DRPC clients with adapters.

Epic: CRDB-48923
Fixes:#148353
Release note: none

Author: cthumuluru-crdb

pkg/kv/kvserver/client_raft_test.go

@@ -4667,7 +4667,7 @@ func TestStoreRangeWaitForApplication(t *testing.T) {
 
 			atomic.StoreInt64(&filterRangeIDAtomic, int64(desc.RangeID))
 			type target struct {
-				client kvserver.PerReplicaClient
+				client kvserver.RPCPerReplicaClient
 				header kvserver.StoreRequestHeader
 			}
 

pkg/kv/kvserver/rpc_clients.go

@@ -30,16 +30,16 @@ func DialMultiRaftClient(
 
 // DialPerReplicaClient establishes a DRPC connection if enabled; otherwise,
 // it falls back to gRPC. The established connection is used to create a
-// PerReplicaClient.
+// RPCPerReplicaClient.
 func DialPerReplicaClient(
 	nd rpcbase.NodeDialer, ctx context.Context, nodeID roachpb.NodeID, class rpcbase.ConnectionClass,
-) (PerReplicaClient, error) {
+) (RPCPerReplicaClient, error) {
 	if !rpcbase.TODODRPC {
 		conn, err := nd.Dial(ctx, nodeID, class)
 		if err != nil {
 			return nil, err
 		}
-		return NewPerReplicaClient(conn), nil
+		return NewGRPCPerReplicaClientAdapter(conn), nil
 	}
 	return nil, nil
 }

pkg/server/authserver/authentication_test.go

@@ -846,7 +846,7 @@ func TestGRPCAuthentication(t *testing.T) {
 			return err
 		}, true},
 		{"perReplica", func(ctx context.Context, conn *grpc.ClientConn) error {
-			_, err := kvserver.NewPerReplicaClient(conn).CollectChecksum(ctx, &kvserver.CollectChecksumRequest{})
+			_, err := kvserver.NewGRPCPerReplicaClientAdapter(conn).CollectChecksum(ctx, &kvserver.CollectChecksumRequest{})
 			return err
 		}, true},
 		{"raft", func(ctx context.Context, conn *grpc.ClientConn) error {