Skip to content

Commit 9ab7189

Browse files
committed
tests: avoid t.Parallel() when the top test has defers
Sub-tests that invoke `t.Parallel()` get to run concurrently with their parent test, and may be delayed arbitrarily past beyond the end of the termination of the parent test (including beyond the execution of its `defer` calls). This means it's unsafe to call `t.Parallel()` with e.g. `leaktest.AfterTest()`. This patch removes `t.Parallel` from the test in `sql/physical_props_test.go` and modifies `pkg/rpc/TestGRPCKeepaliveFailureFailsInflightRPCs` to use a wait group instead. Release note: None
1 parent d50ebea commit 9ab7189

File tree

2 files changed

+214
-175
lines changed

2 files changed

+214
-175
lines changed

0 commit comments

Comments
 (0)