Fix lint errors and sigsev

Author: marc

c-deps/libroach/db.cc

@@ -1700,7 +1700,7 @@ DBStatus DBOpen(DBEngine **db, DBSlice dir, DBOptions db_opts) {
     options.env = memenv.get();
   }
 
-  PreambleHandler* preamble;
+  PreambleHandler* preamble = nullptr;
   if (db_opts.use_preamble) {
     // The caller makes sure we're not an in-memory DB.
     assert(dir.len != 0);

pkg/storage/engine/rocksdb_test.go

@@ -263,7 +263,9 @@ func TestRocksDBOpenWithVersions(t *testing.T) {
 
 // openRocksDBWithVersion attempts to open a rocks db instance, optionally with
 // the supplied Version struct.
-func openRocksDBWithVersion(t *testing.T, hasVersionFile bool, ver Version, wantPreambleFormat bool) (Version, error) {
+func openRocksDBWithVersion(
+	t *testing.T, hasVersionFile bool, ver Version, wantPreambleFormat bool,
+) (Version, error) {
 	dir, err := ioutil.TempDir("", "testing")
 	if err != nil {
 		t.Fatal(err)

pkg/storage/engine/version_test.go

@@ -50,7 +50,7 @@ func TestVersions(t *testing.T) {
 
 	// Write the same version to the file: not allowed.
 	if err := writeVersionFile(dir, ver); !testutils.IsError(err, "writing version 0 is not allowed") {
-		t.Errorf("expected error '%s', got '%v'", "writing version 0 is not allowed")
+		t.Errorf("expected error '%s', got '%v'", "writing version 0 is not allowed", err)
 	}
 
 	// Try again with current version.