Merge #28681

craig[bot] · vivekmenezes · craig[bot] · commit d556fa9bfb9b · 2018-08-16T10:30:11.000Z
28681: sql: speed up two schema change tests by a bit r=vivekmenezes a=vivekmenezes

speed up TestSchemaChangeRetry and
TestSchemaChangeRetryOnVersionChange by
reducing the data used in these tests.

Release note: None

Co-authored-by: Vivek Menezes &lt;vivek@cockroachlabs.com&gt;
diff --git a/pkg/sql/schema_changer_test.go b/pkg/sql/schema_changer_test.go
@@ -1338,7 +1338,7 @@ CREATE TABLE t.test (k INT PRIMARY KEY, v INT);
 	}
 
 	// Bulk insert.
-	const maxValue = 5000
+	const maxValue = 2000
 	if err := bulkInsertIntoTable(sqlDB, maxValue); err != nil {
 		t.Fatal(err)
 	}
@@ -1437,7 +1437,7 @@ CREATE TABLE t.test (k INT PRIMARY KEY, v INT);
 	}
 
 	// Bulk insert.
-	maxValue := 5000
+	maxValue := 2000
 	if err := bulkInsertIntoTable(sqlDB, maxValue); err != nil {
 		t.Fatal(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -1338,7 +1338,7 @@ CREATE TABLE t.test (k INT PRIMARY KEY, v INT);`
`1338`	`1338`	`}`
`1339`	`1339`
`1340`	`1340`	`// Bulk insert.`
`1341`		`- const maxValue = 5000`
	`1341`	`+ const maxValue = 2000`
`1342`	`1342`	`if err := bulkInsertIntoTable(sqlDB, maxValue); err != nil {`
`1343`	`1343`	`t.Fatal(err)`
`1344`	`1344`	`}`
`@@ -1437,7 +1437,7 @@ CREATE TABLE t.test (k INT PRIMARY KEY, v INT);`
`1437`	`1437`	`}`
`1438`	`1438`
`1439`	`1439`	`// Bulk insert.`
`1440`		`- maxValue := 5000`
	`1440`	`+ maxValue := 2000`
`1441`	`1441`	`if err := bulkInsertIntoTable(sqlDB, maxValue); err != nil {`
`1442`	`1442`	`t.Fatal(err)`
`1443`	`1443`	`}`