Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stmtbundle: handle multi-line cluster setting values in recreate #119786

Closed
yuzefovich opened this issue Feb 29, 2024 · 0 comments · Fixed by #123794
Closed

stmtbundle: handle multi-line cluster setting values in recreate #119786

yuzefovich opened this issue Feb 29, 2024 · 0 comments · Fixed by #123794
Assignees
@yuzefovich
Labels
A-sql-debug-bundle Issues related to statement bundle improvements C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Feb 29, 2024 •
edited
Loading

When attempting to recreate a bundle from here, we get a syntax error because the cluster setting sql.log.user_audit has non-default value that is multi-line. We should handle such cases gracefully.

A related improvement is to handle non-default session variables like SET timezone = Etc/UTC correctly too (currently missing quotes).

Jira issue: CRDB-36314
@yuzefovich yuzefovich added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team A-sql-debug-bundle Issues related to statement bundle improvements labels Feb 29, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Feb 29, 2024
@yuzefovich yuzefovich added the E-quick-win Likely to be a quick win for someone experienced. label Feb 29, 2024
@yuzefovich yuzefovich moved this from Triage to New Backlog in SQL Queries Feb 29, 2024
@yuzefovich yuzefovich mentioned this issue Feb 29, 2024
Closed
@yuzefovich yuzefovich mentioned this issue May 8, 2024
Merged
@yuzefovich yuzefovich self-assigned this May 8, 2024
@yuzefovich yuzefovich moved this from Backlog to Active in SQL Queries May 8, 2024
@craig craig bot closed this as completed in 992d457 May 16, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries May 16, 2024
@yuzefovich yuzefovich mentioned this issue Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-debug-bundle Issues related to statement bundle improvements C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: improve env collection in stmt bundles yuzefovich/cockroach
1 participant
@yuzefovich