roachtest: run nightlies with assertions enabled #128841
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-testeng
TestEng Team
In #111949 we briefly enabled roachtest nightlies to run with the
crdb_test
flag on. This enabled roachtests to be run with runtime assertions as well as metamorphic constants. However, due to the "metamorphic" nature of metamorphic constants, it was difficult to test all possible combinations/constants and tests frequently flaked. To reduce noise, we disabled both runtime assertions and metamorphic constants in #114618.Runtime assertions however, seemed to be more stable. In terms of infra flakes, we expect they might contribute to longer run times, but other failures are likely actual assertions hit or issues with the assertion themselves. We should look into reenabling just runtime assertions on roachtest nightlies.
Runtime assertions and metamorphic constants are both enabled by default when building with
--crdb_test
. To disable metamorphic constants,COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true
should be passed in when the cluster is started.Related work/issues also includes:
COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true
on cluster startup is sufficient to disable constants in the cluster, but it won't stop logging on every cockroach binary invocation, i.e../cockroach workload
Jira issue: CRDB-41227
The text was updated successfully, but these errors were encountered: