sql: investigate Hibernate's testTemporalType

[BramGruneir]

from org.hibernate.test.annotations.EntityTest testTemporalType

Somehow, a timestamp changes values. I'm not sure if this is happening during the write or the read. More investigation is requried.

create table Flight (                                                                                                                            
  id int8 not null,                                                                                                                                                          
  alternativeDepartureDate timestamp,                                                                                                                                       
  primary key (id)                                                                                                                                                      
);
insert into Flight (id, alternativeDepartureDate) values (1, '1970-01-02 04:59:27.443');
select * from Flight;

In the hibernate test output, the value changes:

org.junit.ComparisonFailure: expected:<January 2, 1970 at [4]:59:27 AM EST> but was:<January 2, 1970 at [9]:59:27 AM EST>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.hibernate.test.annotations.EntityTest.lambda$testTemporalType$1(EntityTest.java:403)
...

[BramGruneir]

6 more failures:

• org.hibernate.test.cid.CompositeIdWithGeneratorTest
  • testCompositeIdSimple
  • testDetachedId
  • testDetachedProperty
  • testEvict
  • testLoad
  • testMerge

[knz]

This is a time zone problem. Check what is the default time zone expected.

[knz]

What is the full syntax of the CREATE TABLE statement? It's truncated above. We need this to fully investigate.

[BramGruneir]

That seems like the most plausible explanation.

[knz]

@BramGruneir This issue is improperly qualified. It does neither state what is the deviation (difference between expected behavior and actual behavior) nor what action items should be carried out.

Unless you provide either (preferably both), we can't do anything with this.

[BramGruneir]

The expected behaviour and actual are spelled out in the issue.

org.junit.ComparisonFailure: expected:<January 2, 1970 at [4]:59:27 AM EST> but was:<January 2, 1970 at [9]:59:27 AM EST>

And the create table statement was there in full. Just poorly formatted. It has been fixed.

And I still agree, this is most likely a time zone issue.

[knz]

The problem might be in Hibernate's testTemporalType instead of CockroachDB. We simply don't know. Renamed the issue to reflect the investigation to be done, instead of the working theory.

[jordanlewis]

All of the tests in this issue pass now, as of 2.1! 🎉