Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql: high-level retry on connection failures #28703

Closed
jordanlewis opened this issue Aug 16, 2018 · 2 comments
Closed

distsql: high-level retry on connection failures #28703

jordanlewis opened this issue Aug 16, 2018 · 2 comments
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity

Comments

@jordanlewis
Copy link
Member

Currently, DistSQL is not resilient to connection failures after flows have been setup - the failure will simply bubble all the way up through SQL to the user.

This is generally bad - our system shouldn't start failing queries when nodes die, or in the new circuit-breaker-y world, when a connection can't be established to a particular node because of a 500ms cooldown period.

We should add a high-level retry loop, above distsql physical planning, that activates if the failure that it sees is about connection failure or breaker tripped. I think it's only valid to do so for read-only queries, as well.

@jordanlewis jordanlewis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-execution Relating to SQL execution. labels Aug 16, 2018
@jordanlewis jordanlewis added this to the 2.2 milestone Aug 16, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@jordanlewis
Copy link
Member Author

I think this is the wrong way to do things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants