Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support COMMENT ON for table columns #32965

Closed
knz opened this issue Dec 9, 2018 · 1 comment
Closed

sql: support COMMENT ON for table columns #32965

knz opened this issue Dec 9, 2018 · 1 comment
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience help wanted Help is requested / needed by the one who filed the issue to fix it.

Comments

@knz
Copy link
Contributor

knz commented Dec 9, 2018

This is pursuant of #32442 towards #19472.

PR #32442 has added infrastructure which is extensible towards documenting columns. The corresponding support for COMMENT ON <col> can then be added.
@knz knz added E-easy Easy issue to tackle, requires little or no CockroachDB experience A-sql-vtables Virtual tables - pg_catalog, information_schema etc C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-schema-descriptors Relating to SQL table/db descriptor handling. and removed A-sql-vtables Virtual tables - pg_catalog, information_schema etc labels Dec 9, 2018
@knz knz added the help wanted Help is requested / needed by the one who filed the issue to fix it. label Dec 9, 2018
@knz knz mentioned this issue Dec 9, 2018
Closed
@flokli flokli mentioned this issue Dec 9, 2018
Closed
4 tasks
@knz
Copy link
Contributor Author

knz commented Dec 31, 2018

Closed by #33355

@knz knz closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience help wanted Help is requested / needed by the one who filed the issue to fix it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz