Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: poll conformance reports in partitioned tpccbench #44999

Closed
nvanbenschoten opened this issue Feb 12, 2020 · 2 comments
Closed

roachtest: poll conformance reports in partitioned tpccbench #44999

nvanbenschoten opened this issue Feb 12, 2020 · 2 comments

Comments

@nvanbenschoten
Copy link
Member

tpccbench waits for a predefined period of time (a function of the number of warehouses) to give recently imported clusters time to get into conformance with their partition configuration.

rebalanceWait = time.Duration(b.LoadWarehouses/50) * time.Minute

This would be much better served by polling the replication constraint conformance reports and waiting until the cluster is not in violation of any of its partition constraints. We'd also likely want to wait until leaseholders are well-balanced.

@nvanbenschoten
Copy link
Member Author

@andreimatei do you have any interest in doing something here during this stability period?

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants