Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Rendering of node names is inconsistent in the code #45622

Closed
dhartunian opened this issue Mar 3, 2020 · 4 comments · Fixed by #45665
Closed

ui: Rendering of node names is inconsistent in the code #45622

dhartunian opened this issue Mar 3, 2020 · 4 comments · Fixed by #45665
Assignees
Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. good first issue

Comments

@dhartunian
Copy link
Collaborator

Currently a lot of different code is responsible for rendering node names in the Admin UI. It would make sense to standardize on a single format and ensure that one place in the code is responsible. We're not too far from this since the number of code spots are few for now.

Ideally we can either change the types in the code to make it easier to use the getDisplayName function that already exists or modify the types we're using and the function to make them work well together.

See #45551 for examples.

@dhartunian dhartunian added good first issue A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. labels Mar 3, 2020
@girishramnani
Copy link

My initial search in the code shows these 2 places which need the change

1 -

<span className="noConnections__table--item__bold">{`N${value.from.nodeID}: `}</span>

2 -

<span className="noConnections__table--item__bold">{`N${value.to.nodeID}: `}</span>

@girishramnani
Copy link

opened a PR which changes both of these places #45665

If there are any other places then I can change those too.

@girishramnani
Copy link

girishramnani commented Mar 3, 2020

@dhartunian if you could assign this issue to me then that would be amazing

@girishramnani
Copy link

Thanks for the assign @nathanstilwell

@craig craig bot closed this as completed in 36fd3c5 Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants