Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: support debug zip --anonymize #46031

Closed
irfansharif opened this issue Mar 12, 2020 · 2 comments · Fixed by #48051
Closed

cli: support debug zip --anonymize #46031

irfansharif opened this issue Mar 12, 2020 · 2 comments · Fixed by #48051
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@irfansharif
Copy link
Contributor

We should provide this switch so that diagnosing of issues is not hindered by manual scrubbing by the user -- which could be prone to mistakes as well.

Few examples:

  • The table/key names (XXXX) in log lines:
I200311 07:21:32.053215 826880069 storage/replica_command.go:797 [n8,replicate,s8,r16277/42:/Table/131{-/1/"XXXX…}] change replicas (REMOVE_REPLICA (n5,s5):37): read existing descriptor r16277:/Table/131{-/1/"XXXX^51b23f4c1607fe220acebc023621568f"} [(n4,s4):40, (n8,s8):42, (n5,s5):37, (n11,s11):43, next=44, gen=8]
  • The same as above in range reports, rangelog.json
  • User names used to log into the admin UI
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 24, 2020
@onno-vos-dev
Copy link

@irfansharif Just want to +1 this issue. I've been asked to provide a debug zip a few times now but due to restrictions have to make sure I scrub all PII from the dump. Currently I got some crazy sed commands to deal with this but having an anonymize flag as proposed here would me sleep a little bit better 😄

I see there's already a PR ongoing for it, if you'd like I'm happy to pitch in 👍

@irfansharif
Copy link
Contributor Author

I empathize with your pain! Hopefully there's not much of that before long. There's a bit of design work ongoing by @knz over at #48076, that you may be interested in.

@craig craig bot closed this as completed in 0dd70ca Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants