Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulkio: lock down RESTORE/IMPORT/BACKUP on sql tenants #47913

Closed
tbg opened this issue Apr 22, 2020 · 3 comments
Closed

bulkio: lock down RESTORE/IMPORT/BACKUP on sql tenants #47913

tbg opened this issue Apr 22, 2020 · 3 comments
Assignees
Labels
A-multitenancy Related to multi-tenancy E-quick-win Likely to be a quick win for someone experienced. T-disaster-recovery

Comments

@tbg
Copy link
Member

tbg commented Apr 22, 2020

SQL tenants must not use RESTORE/IMPORT. This is because it won't work (without extra engineering work not slated for phase 2) but also because we can't have SQL tenants make arbitrary connections to the outside world.
Additionally, IMPORT INTO uses protected timestamps which won't be available.

All import/restore related functionality ought to be disabled for SQL tenant servers.

Should wait for #47903 to close.

Jira issue: CRDB-4377

@pbardea
Copy link
Contributor

pbardea commented Apr 22, 2020

From the sounds of this, BACKUP should also be locked down, correct? It doesn't pull in data from the outside world, but it does open a connection to the outside world. It also currently uses protected timestamps.

@tbg
Copy link
Member Author

tbg commented Apr 22, 2020

Yes, that sounds right. Note that protected timestamps are optional in backup (ie we could skip them) but letting tenants take backups of their logical data is definitely out of scope, so we should lock it down too.

@tbg tbg changed the title bulkio: lock down RESTORE/IMPORT on sql tenants bulkio: lock down RESTORE/IMPORT/BACKUP on sql tenants Apr 22, 2020
@RaduBerinde RaduBerinde added the E-quick-win Likely to be a quick win for someone experienced. label Nov 11, 2021
@knz
Copy link
Contributor

knz commented Jun 14, 2022

This has been addressed, and moreover we're going to allow tenants to run these bulk i/o operations.

@knz knz closed this as completed Jun 14, 2022
@knz knz self-assigned this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy E-quick-win Likely to be a quick win for someone experienced. T-disaster-recovery
Projects
Archived in project
Development

No branches or pull requests

5 participants