Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: long-running migration to finally remove pre-19.2 foreign keys #48743

Closed
thoszhang opened this issue May 12, 2020 · 2 comments
Closed

sql: long-running migration to finally remove pre-19.2 foreign keys #48743

thoszhang opened this issue May 12, 2020 · 2 comments
Assignees
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@thoszhang
Copy link
Contributor

Currently we're upgrading FKs from the pre-19.2 style representation to the current representation on the fly, not writing them back to disk until we update the table descriptor, so in theory there could still be old-style foreign keys on clusters started in version 19.1 or earlier. We need a long-running migration (#39182) to get rid of these once and for all.

@thoszhang thoszhang added the A-schema-descriptors Relating to SQL table/db descriptor handling. label May 12, 2020
@blathers-crl
Copy link

blathers-crl bot commented May 12, 2020

Hi @lucy-zhang, please add a C-ategory label to your issue. Check out the label system docs.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@thoszhang thoszhang added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label May 12, 2020
@thoszhang
Copy link
Contributor Author

#60510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Development

No branches or pull requests

2 participants