Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rowexec/colexec: add cumulative contention time to EXPLAIN ANALYZE #56612

Closed
asubiotto opened this issue Nov 12, 2020 · 0 comments · Fixed by #56906
Closed

rowexec/colexec: add cumulative contention time to EXPLAIN ANALYZE #56612

asubiotto opened this issue Nov 12, 2020 · 0 comments · Fixed by #56906
Assignees
@asubiotto
Labels
A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@asubiotto
Copy link
Contributor

Actual contention events will be implemented in #55583, but in the meantime we can introduce a testing cluster setting that will produce mock contention events that follow the same structure as that defined by the issue.

This issue also tracks building the SQL execution infrastructure around those contention events. To start with, we'll want to surface how much contention happened in any operators that use disk. This should be a sum of the duration of each contention event.
@asubiotto asubiotto added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer labels Nov 12, 2020
@asubiotto asubiotto self-assigned this Nov 12, 2020
This was referenced Nov 17, 2020
Closed
Merged
@craig craig bot closed this as completed in 5faa952 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
A-sql-execution Relating to SQL execution. A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: produce mock ContentionEvents and display contention time in EXPLAIN ANALYZE
1 participant
@asubiotto