Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: include active trace spans in debug.zip #58608

Closed
tbg opened this issue Jan 7, 2021 · 4 comments · Fixed by #60922
Closed

cli: include active trace spans in debug.zip #58608

tbg opened this issue Jan 7, 2021 · 4 comments · Fixed by #60922
Assignees
Labels
A-kv-observability A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@tbg
Copy link
Member

tbg commented Jan 7, 2021

Is your feature request related to a problem? Please describe.
Now that we have a way to observe long-running trace spans, we should also include them in debug.zip:

#55592

Describe the solution you'd like
Either dump (a suitably filtered) select on #55733 or add and hit an API endpoint straight into the registry.

The latter might be preferrable if we want Jaeger-compatible output.

Describe alternatives you've considered

Additional context

@tbg tbg added A-kv-observability A-tracing Relating to tracing in CockroachDB. labels Jan 7, 2021
@blathers-crl
Copy link

blathers-crl bot commented Jan 7, 2021

Hi @tbg, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jan 7, 2021
@tbg
Copy link
Member Author

tbg commented Jan 7, 2021

Note that this motivates #58610

@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Jan 7, 2021
@angelapwen
Copy link

Just noticed this issue: have already included a select into debug.zip for the long-running trace spans vtable in #59492 but we can leave this open if we want the Jaeger-compatible output.

@tbg
Copy link
Member Author

tbg commented Feb 23, 2021

To close this issue, we should also include the payloads for all of the long-running trace spans via #60922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-observability A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants