Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: lease extensions can be rejected due to raft follower status #59179

Closed
nvanbenschoten opened this issue Jan 20, 2021 · 1 comment · Fixed by #61982
Closed

kv: lease extensions can be rejected due to raft follower status #59179

nvanbenschoten opened this issue Jan 20, 2021 · 1 comment · Fixed by #61982
Assignees
@erikgrinaker
Labels
A-kv-distribution Relating to rebalancing and leasing. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@nvanbenschoten
Copy link
Member

Currently, the propBuf can reject extensions of an existing lease because the current leaseholder is not the raft leader. This was not the intention of the rejection logic in the propBuf and should be avoided.

This motivates a change like nvanbenschoten@b437722.
@nvanbenschoten nvanbenschoten added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-distribution Relating to rebalancing and leasing. labels Jan 20, 2021
@tbg
Copy link
Member

tbg commented Mar 9, 2021

@erikgrinaker since it's looking like you're running out of queue soon, would you take this on? The change is trivial, most of the work is to write a test, for which you can look to replica_proposal_buf_test.go.

@tbg tbg assigned erikgrinaker and unassigned andreimatei Mar 9, 2021
@erikgrinaker erikgrinaker mentioned this issue Mar 14, 2021
Merged
@craig craig bot closed this as completed in af06665 Mar 24, 2021
@erikgrinaker erikgrinaker mentioned this issue Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-distribution Relating to rebalancing and leasing. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: allow lease extensions from followers in propBuf erikgrinaker/cockroach
4 participants
@andreimatei @erikgrinaker @tbg @nvanbenschoten