You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We may build partial index and unique constraint predicates multiple times in optbuilder. For example, an INSERT ON CONFLICT will build a partial unique constraint predicate when determining arbiters and when building uniqueness checks. We should consider caching the built expressions to the table metadata.
Also, we may be able to eliminate any rebuilding of partial index predicates in arbiter-related code by using the predicates already built in the fetchScope (assuming we build and assign mutationBuilder.fetchScope before we try to find arbiters.
Finally, we build a partial unique constraint predicate thrice when building uniqueness checks for UPDATEs: to determine the column ordinals referenced in the predicate, to filter the WithScan, and to filter the Scan.
We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!
We may build partial index and unique constraint predicates multiple times in
optbuilder
. For example, anINSERT ON CONFLICT
will build a partial unique constraint predicate when determining arbiters and when building uniqueness checks. We should consider caching the built expressions to the table metadata.Also, we may be able to eliminate any rebuilding of partial index predicates in arbiter-related code by using the predicates already built in the fetchScope (assuming we build and assign
mutationBuilder.fetchScope
before we try to find arbiters.Finally, we build a partial unique constraint predicate thrice when building uniqueness checks for
UPDATE
s: to determine the column ordinals referenced in the predicate, to filter the WithScan, and to filter the Scan.Jira issue: CRDB-3096
The text was updated successfully, but these errors were encountered: