Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: investigate kv95 regression around Feb 18 #62148

Closed
tbg opened this issue Mar 17, 2021 · 2 comments
Closed

kv: investigate kv95 regression around Feb 18 #62148

tbg opened this issue Mar 17, 2021 · 2 comments
Assignees
@erikgrinaker @irfansharif @angelapwen
Labels
C-investigation Further steps needed to qualify. C-label will change. C-performance Perf of queries or internals. Solution not expected to change functional behavior. GA-blocker

Comments

@tbg
Copy link
Member

tbg commented Mar 17, 2021

See https://groups.google.com/a/cockroachlabs.com/d/msgid/eng/CABz5gWE%3DsO75sEtqB3MjA6ZcDqzKk%3DQhoXLVsMXkUHbtmHVuzg%40mail.gmail.com?utm_medium=email&utm_source=footer (internal) and

https://roachperf.crdb.dev/?filter=&view=kv95%2Fenc%3Dfalse%2Fnodes%3D3&tab=aws (internal).
@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2021

Hi @tbg, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@tbg tbg added the C-investigation Further steps needed to qualify. C-label will change. label Mar 17, 2021
@tbg tbg added the GA-blocker label Mar 17, 2021
@irfansharif irfansharif self-assigned this Mar 17, 2021
@erikgrinaker erikgrinaker added the C-performance Perf of queries or internals. Solution not expected to change functional behavior. label Mar 17, 2021
@irfansharif irfansharif mentioned this issue Mar 18, 2021
Closed
@erikgrinaker erikgrinaker mentioned this issue Mar 21, 2021
Closed
15 tasks
@erikgrinaker erikgrinaker changed the title kv: investigate kv95 regression around 2/20/2021 kv: investigate kv95 regression around Feb 18 Mar 22, 2021
@erikgrinaker
Copy link
Contributor

The regression on Feb 18 was due to #59992, and was fixed by #61777. This was verified by cherry-picking the fix onto the initial PR merge, and showing that it recovered performance with sampling=0. Separate work is underway to improve performance with sampling enabled.

This means there were other performance regressions in the period after Feb 18 that counteracted #61777. Will open a separate issue for this.

@erikgrinaker erikgrinaker mentioned this issue Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

@irfansharif irfansharif

@angelapwen angelapwen

Labels
C-investigation Further steps needed to qualify. C-label will change. C-performance Perf of queries or internals. Solution not expected to change functional behavior. GA-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erikgrinaker @tbg @irfansharif @angelapwen