Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: refactor pgx_helpers to use pgx/v4 #62840

Closed
RichardJCai opened this issue Mar 31, 2021 · 1 comment · Fixed by #68608
Closed

sql: refactor pgx_helpers to use pgx/v4 #62840

RichardJCai opened this issue Mar 31, 2021 · 1 comment · Fixed by #68608
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@RichardJCai
Copy link
Contributor

RichardJCai commented Mar 31, 2021 •
edited
Loading

Currently pgx_helpers.go and most notably MultiConnPool which is used in workloads uses pgx, upgrading it to pgx/v4 adds many more options for connections such as MaxConnLifetime and MaxConnIdleTime.

Context here:
#62740 (review)
@blathers-crl
Copy link

blathers-crl bot commented Mar 31, 2021

Hi @RichardJCai, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@RichardJCai RichardJCai added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure labels Mar 31, 2021
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@rafiss rafiss mentioned this issue Aug 9, 2021
Merged
@craig craig bot closed this as completed in 472008d Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go.mod: update to pgx v4.13 rafiss/cockroach
2 participants
@rafiss @RichardJCai