-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/ring: TestRingBuffer takes unreasonably long time #65050
Comments
t.Parallel will help a bit. On my machine, the test takes 11.41s, If add func TestRingBufferA(t *testing.T) {
t.Parallel()
for count := 1; count <= maxCount; count++ {
t.Run("Parallel", func(t *testing.T) {
t.Parallel()
testRingBuffer(t, count)
})
}
} The test takes 7.89s, |
@XuanYang-cn thanks for looking into this! I agree, running the subtests in parallel is a good idea. I think it'd be reasonable to reduce the number of runs (i.e. |
@yuzefovich OK,I'll open a pr |
From #65045 (comment):
We should investigate why it is so and make it faster. Also see #63388 - hopefully we can revert that change too.
The text was updated successfully, but these errors were encountered: