-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: Support 'COMMENT ON SCHEMA' #67689
Comments
Thanks, you're absolutely right. Please feel free to take a stab at the PR! |
Hi, I would like to work on this PR. |
we don't "reserve" PRs for one person. Anyone should free to work on it; you don't have to announce your work ahead of time. |
Hey! I would like to work on this issue, but I have absolutely no clue where to start. Can someone point me to some relevant documentation/internal docs? |
What about you look at the previous PRs that implemented COMMENT ON TABLE / COMMENT ON DATABASE, then do something similar. |
Is your feature request related to a problem? Please describe.
COMMENT ON SCHEMA
is not supported.Describe the solution you'd like
COMMENT ON SCHEMA
is supported.Support for
COMMENT ON
for tables, table columns, and databases was implemented in 2019 for #19472 then the issue was closed by @jordanlewis because schemas were not supported at all: #19472 (comment)CREATE SCHEMA
was implemented in 2020 #50613 thereforeCOMMENT ON SCHEMA
is (should be?) unblocked. Might be a good first PR as there are examples in:I may implement the PR, but am not claiming it yet.
Describe alternatives you've considered
I am skipping unsupported SQL.
The text was updated successfully, but these errors were encountered: