Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: run some (most?) roachtests with tracing enabled #71663

Closed
ajwerner opened this issue Oct 18, 2021 · 1 comment
Closed

roachtest: run some (most?) roachtests with tracing enabled #71663

ajwerner opened this issue Oct 18, 2021 · 1 comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity O-roachtest X-stale

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Oct 18, 2021 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.

We want to see when tracing causes performance pain. One good way to catch these would be to see the overhead in some benchmarks we track. Consider adding a few new roachperf configurations for kv, ycsb, tpcc that have tracing enabled.

Another thought is that maybe for the non-performance-centric we should enable tracing as it may exercise edge cases.

Additional context
Relates to #58610.

Jira issue: CRDB-10707
@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure O-roachtest labels Oct 18, 2021
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity O-roachtest X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhartunian @ajwerner