Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: transmit tenantID in grpc metadata #75795

Closed
knz opened this issue Feb 1, 2022 · 0 comments · Fixed by #96153
Closed

server: transmit tenantID in grpc metadata #75795

knz opened this issue Feb 1, 2022 · 0 comments · Fixed by #96153
Assignees
@knz
Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security

Comments

@knz
Copy link
Contributor

knz commented Feb 1, 2022 •
edited
Loading

Found by @jeffswenson and @tbg in #75766

When running with TLS disabled, we lose access to the tenantID in the RPCs from SQL servers to KV nodes.

To fix this, we'd want to put the tenantID also into grpc metadata. And use grpc metadata on the KV side.

Jira issue: CRDB-12838

Epic: CRDB-14537
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team labels Feb 1, 2022
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Feb 1, 2022
@knz knz mentioned this issue Feb 1, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot removed the T-multitenant Issues owned by the multi-tenant virtual team label Mar 10, 2022
@knz knz mentioned this issue Nov 17, 2022
Closed
@knz knz mentioned this issue Jan 29, 2023
Merged
@knz knz mentioned this issue Jan 30, 2023
Closed
@craig craig bot closed this as completed in 581560b Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc,security: allow setting the tenant ID via gRPC metadata knz/cockroach
1 participant
@knz