Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowexec: problem with an empty tuple during spilling to disk #78696

Open
yuzefovich opened this issue Mar 29, 2022 · 2 comments
Open

rowexec: problem with an empty tuple during spilling to disk #78696

yuzefovich opened this issue Mar 29, 2022 · 2 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Mar 29, 2022

The following logic test will fail when run via the row-by-row engine:

# LogicTest: local-vec-off

statement ok
SET distsql_workmem = '2B'

query T
SELECT
  col
FROM
  (VALUES ((ARRAY[]::RECORD[])), ((ARRAY[()])))
    AS t(col)
ORDER BY
  col ASC
----
{}
{()}

The idea is that we're forcing the sort to spill to disk, so both array go through encoding/decoding process. We have arrays of tuple, and we need to use the key encoding. The key encoding for both tuples ends up being the same.

Jira issue: CRDB-14222

@yuzefovich yuzefovich added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 29, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 29, 2022
@yuzefovich
Copy link
Member Author

@rafiss given your work in #70767, does this issue seem important enough that we'll ever want to fix it? I think probably not, so I'm putting it straight on backlog.

@mgartner mgartner moved this to Backlog (DO NOT ADD NEW ISSUES) in SQL Queries Jul 24, 2023
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@yuzefovich yuzefovich moved this from Backlog (DO NOT ADD NEW ISSUES) to Bugs to Fix in SQL Queries Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
Status: Bugs to Fix
Development

No branches or pull requests

1 participant