Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: show a notice when SET CLUSTER SETTING sql.defaults... is used #80325

Closed
rafiss opened this issue Apr 21, 2022 · 0 comments · Fixed by #80548
Closed

sql: show a notice when SET CLUSTER SETTING sql.defaults... is used #80325

rafiss opened this issue Apr 21, 2022 · 0 comments · Fixed by #80548
Assignees
@e-mbrown
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Apr 21, 2022 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
We should direct people to start using the ALTER ROLE syntax for session variable defaults.

Describe the solution you'd like
Modify func (n *setClusterSettingNode) startExec in pkg/sql/set_cluster_setting.go so that it shows a notice when a sql.defaults cluster setting is used. The message should just mention that ALTER ROLE ... SET syntax can control session variable defaults at a finer-grained level, and link to the docs.

Use params.p.BufferClientNotice() to send the message.

Epic CRDB-10463

Jira issue: CRDB-15766
@rafiss rafiss added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 21, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Apr 21, 2022
@e-mbrown e-mbrown mentioned this issue Apr 26, 2022
Merged
@craig craig bot closed this as completed in a5e3f4a May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-mbrown e-mbrown

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add a SET CLUSTER SETTING sql.defaults deprecation notice e-mbrown/cockroach
3 participants
@jlinder @rafiss @e-mbrown