Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: debug backup export not tested (maybe not working) for tenant backups #82878

Closed
knz opened this issue Jun 14, 2022 · 3 comments
Closed
Labels
A-disaster-recovery A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery

Comments

@knz
Copy link
Contributor

knz commented Jun 14, 2022

Describe the problem

When we look at the implementation of cockroach backup export we see that it uses keys.TODOSQLCodec to report the contents of a backup.

This is not likely to work if the backup files contain data for a tenant.

In addition, we see that backup export is not being tested for tenant backups in ccl/cliccl, alongside the other cases in debug_backup_test.go.

Expected behavior

There are passing unit tests in ccl/cliccl that exercise debug backup export for tenant backups.

cc @stevendanna for triage

Jira issue: CRDB-16703

Epic: CRDB-14582

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery A-multitenancy Related to multi-tenancy T-disaster-recovery labels Jun 14, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2022

cc @cockroachdb/bulk-io

@shermanCRL
Copy link
Contributor

FYI this is not (should not) be enabled in production. We never shipped it. We still could but it’s low priority.

@knz
Copy link
Contributor Author

knz commented Jun 14, 2022

Thanks for the heads up.

Regardless of whether the code is in prod or not, we need to do this cleanup within 1-2 release cycle for the multi-tenancy arch unification project. If you believe this code is not going to be maintained moving forward, we can schedule removing it from the project altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants