Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: create linter to prevent checking in underscore-prefixed test files #85457

Open
mgartner opened this issue Aug 2, 2022 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@mgartner
Copy link
Collaborator

mgartner commented Aug 2, 2022

As of #85386, logic test files that start with an underscore are considered "temporary" files that run in the TestLogic_tmp test. They are meant for local development and debugging, and they shouldn't be checked in to the repository. We should create a linter to enforce this. See the discussion: #85386 (review)

Jira issue: CRDB-18254

@mgartner mgartner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 2, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Aug 2, 2022
@mgartner mgartner added the E-quick-win Likely to be a quick win for someone experienced. label Aug 2, 2022
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
Status: Backlog
Development

No branches or pull requests

1 participant