Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/serverccl: TestSQLServer failed #85508

Closed
cockroach-teamcity opened this issue Aug 3, 2022 · 2 comments · Fixed by #85621
Closed

ccl/serverccl: TestSQLServer failed #85508

cockroach-teamcity opened this issue Aug 3, 2022 · 2 comments · Fixed by #85621
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 3, 2022 •
edited by cockroach-jira-scripts
Loading

ccl/serverccl.TestSQLServer failed with artifacts on master @ 47d34c9dd0c63dfd462e4380a65470f4cf18e3d6:

=== RUN   TestSQLServer
    test_log_scope.go:162: test logs captured to: /artifacts/tmp/_tmp/bdf0d69e85b4e9625d25e2f39af80117/logTestSQLServer4019235114
    test_log_scope.go:80: use -show-logs to present logs inline

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/multi-tenant @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-18277
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Aug 3, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Aug 3, 2022
@cockroach-teamcity
Copy link
Member Author

ccl/serverccl.TestSQLServer failed with artifacts on master @ 5f854ce368440e2289af5db321f7330dbef87639:

=== RUN   TestSQLServer
    test_log_scope.go:162: test logs captured to: /artifacts/tmp/_tmp/bdf0d69e85b4e9625d25e2f39af80117/logTestSQLServer921214600
    test_log_scope.go:80: use -show-logs to present logs inline

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@rafiss
Copy link
Collaborator

rafiss commented Aug 4, 2022

There is a race. @yuzefovich I saw that you worked on makeSQLInstanceIDForKVNodeIDTenantResolver recently, so assigning you.

==================
WARNING: DATA RACE
Read at 0x00c008c1a000 by goroutine 1978:
  math/rand.(*rngSource).Uint64()
      GOROOT/src/math/rand/rng.go:239 +0x32
  math/rand.(*rngSource).Int63()
      GOROOT/src/math/rand/rng.go:234 +0x1f1
  math/rand.(*Rand).Int63()
      GOROOT/src/math/rand/rand.go:84 +0x70
  math/rand.(*Rand).Int31()
      GOROOT/src/math/rand/rand.go:98 +0x81
  math/rand.(*Rand).Int31n()
      GOROOT/src/math/rand/rand.go:133 +0x45
  math/rand.(*Rand).Intn()
      GOROOT/src/math/rand/rand.go:171 +0x48
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).makeSQLInstanceIDForKVNodeIDTenantResolver.func1()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1335 +0x48b
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).partitionSpan()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1126 +0xdcb
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).partitionSpansTenant()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1227 +0xcac
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PartitionSpans()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1063 +0x5ab
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).planTableReaders()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1686 +0x2b7
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createTableReaders()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1521 +0x773
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlanForPlanNode()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3176 +0x1aa6
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlanForPlanNode()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3122 +0xc8f
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlan()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3080 +0x1c7
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1543 +0x2b3
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1502 +0x1706
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1170 +0x1af7
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:697 +0x66e4
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:146 +0x15b2
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1920 +0x710
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1924 +0x1a84
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1846 +0x70e
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx.func1()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:212 +0x193

Previous write at 0x00c008c1a000 by goroutine 156:
  math/rand.(*rngSource).Uint64()
      GOROOT/src/math/rand/rng.go:239 +0x44
  math/rand.(*rngSource).Int63()
      GOROOT/src/math/rand/rng.go:234 +0x1f1
  math/rand.(*Rand).Int63()
      GOROOT/src/math/rand/rand.go:84 +0x70
  math/rand.(*Rand).Int31()
      GOROOT/src/math/rand/rand.go:98 +0x81
  math/rand.(*Rand).Int31n()
      GOROOT/src/math/rand/rand.go:133 +0x45
  math/rand.(*Rand).Intn()
      GOROOT/src/math/rand/rand.go:171 +0x48
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).makeSQLInstanceIDForKVNodeIDTenantResolver.func1()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1335 +0x48b
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).partitionSpan()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1126 +0xdcb
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).partitionSpansTenant()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1227 +0xcac
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PartitionSpans()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1063 +0x5ab
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).planTableReaders()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1686 +0x2b7
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createTableReaders()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:1521 +0x773
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlanForPlanNode()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3176 +0x1aa6
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlanForPlanNode()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3122 +0xc8f
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).createPhysPlan()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_physical_planner.go:3080 +0x1c7
  github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).PlanAndRun()
      github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1543 +0x2b3
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execWithDistSQLEngine()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1502 +0x1706
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1170 +0x1af7
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:697 +0x66e4
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:146 +0x15b2
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd.func1()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1920 +0x710
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1924 +0x1a84
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
      github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1846 +0x70e
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx.func1()
      github.com/cockroachdb/cockroach/pkg/sql/internal.go:212 +0x193

@yuzefovich yuzefovich mentioned this issue Aug 4, 2022
Merged
@craig craig bot closed this as completed in 60c3679 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

sql: fix recent race on using a random source yuzefovich/cockroach
3 participants
@rafiss @yuzefovich @cockroach-teamcity