Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql, kv: add sql.mutations.max_row_size guardrails #11114

Closed
cockroach-teamcity opened this issue Aug 24, 2021 · 1 comment
Closed

sql, kv: add sql.mutations.max_row_size guardrails #11114

cockroach-teamcity opened this issue Aug 24, 2021 · 1 comment

Comments

@cockroach-teamcity
Copy link
Member

cockroachdb/cockroach#67953 --- Release note (ops change): A new cluster setting, sql.mutations.max_row_size.log, was added, which controls large row logging. Whenever a row larger than this size is written (or a single column family if multiple column families are in use) a LargeRow event is logged to the SQL_PERF channel (or a LargeRowInternal event is logged to SQL_INTERNAL_PERF if the row was added by an internal query). This could occur for INSERT, UPSERT, UPDATE, CREATE TABLE AS, CREATE INDEX, ALTER TABLE, ALTER INDEX, IMPORT, or RESTORE statements. SELECT, DELETE, TRUNCATE, and DROP are not affected by this setting. Release justification: Low risk, high benefit change to existing functionality. This adds logging whenever a large row is written to the database. Default is 64 MiB, which is also the default for kv.raft.command.max_size, meaning on a cluster with default settings statements writing these rows will fail with an error anyway.

@michae2
Copy link

michae2 commented Aug 29, 2021

Note that this setting was renamed, as noted in #11164, and metrics were added, as noted in #11165.

@jseldess jseldess added this to the 21.2 milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants