Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: Consider not virtualizing sstables not truncated at read-time #2583

Open
itsbilal opened this issue Jun 1, 2023 · 0 comments
Open

db: Consider not virtualizing sstables not truncated at read-time #2583

itsbilal opened this issue Jun 1, 2023 · 0 comments

Comments

@itsbilal
Copy link
Member

itsbilal commented Jun 1, 2023

Currently (or at least when #2538 goes in), we will be setting the Virtual flag to true for every shared sstable ingested. This is unnecessary if the sstable was not truncated by the sending node when it produced the SharedSSTMeta. Relaying this information over to the recipient will avoid the need to do the additional key comparisons and bound checks that are necessitated every time we iterate over a virtual sstable, and will be a nice optimization.

Jira issue: PEBBLE-45

Epic CRDB-40358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Disagg - Core
Development

No branches or pull requests

1 participant