-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sstable: prefix bloom filter #5
Comments
@tbg This is done, right? |
No, iterator support is missing. Was planning to continue with that.
…On Wed, Feb 20, 2019, 19:35 Peter Mattis ***@***.*** wrote:
@tbg <https://github.com/tbg> This is done, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/petermattis/pebble/issues/5#issuecomment-465701141>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135MwwEqYH9R7EWunms7roeL8UJmhhks5vPZVugaJpZM4Vt3IK>
.
|
I think this would make a reasonable starter project. What remains to be done is to implement
|
I'm wondering if The benefit that Also, I think In terms of |
Note that we don't want all iterators to be prefix iterators as most scan operations need to find multiple keys, not just keys matching the prefix of the seek key. In CRDB, we specify
Most of the time, the
Agreed.
Agreed. |
I don't recall discussions around the |
@ajkr How do you feel about the proposed API in this PR: |
Taking a look now. Sorry I got addicted to the release problem for too long this week. |
It's a great API. I can barely think of how to misuse it, but let's see :). The only part I didn't get is the discussion around ignoring |
Do we plan for |
Hi Andrew, I initially stated in my PR that However, in the current state of Pebble, setting |
I had forgotten that |
This was fixed by #139. |
Add support for constructing the bloom filter on a prefix of the user key. Add a
Comparator.PrefixExtractor
function for extracting the prefix.One question here is whether this should be considered a prefix extractor or restricted to user keys which have a version. An alternate api would be to provide
Comparator.Split
to split a user key into a prefix and a version suffix. This might be useful in the future for segregating historic versions of user keys into a separate storage area.The text was updated successfully, but these errors were encountered: