False positives for # rubocop:disable Metrics/BlockLength (added in 0.44.0)

[CaseyLeask]

Added in https://github.com/bbatsov/rubocop/releases/tag/v0.44.0 via rubocop/rubocop#3566, this now causes the line

# rubocop:disable Metrics/BlockLength

to give a false positive

Unnecessary disabling of `Metrics/BlockLength` (did you mean `Metrics/LineLength`?).

[pedrorijo91]

@rtfpessoa @machadoit can you have a look at this?

[rtfpessoa]

@CaseyLeask I am not sure I understand the problem. You want us to update Rubocop to the latest version 0.44.0?

[CaseyLeask]

@rtfpessoa In a nutshell, yes.

Rubocop 0.44.0 adds the linting rule Metrics/BlockLength. If this rule is disabled like this

# rubocop:disable Metrics/BlockLength

then codacy-rubocop reports this disabling as unnecessary, and reports this as a code quality issue.

[rtfpessoa]

@CaseyLeask ok, nice. I just did an update.

Next time you need to change the version feel free to send a PR. Usually helps to get it faster into production.

This should be released, worse case, in the next couple of days.