Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CY-6361] version not updating & please add better docs! #62

Open
patrickbland opened this issue Jul 18, 2022 · 2 comments
Open

[CY-6361] version not updating & please add better docs! #62

patrickbland opened this issue Jul 18, 2022 · 2 comments
Labels
jira-issue Issue tracked on JIRA

Comments

@patrickbland
Copy link

patrickbland commented Jul 18, 2022

I really want to follow this module versioning methodology for our mono-repos -- I've spent the past hour trying to use your readme file and versions don't roll using your modules examples.

I also got a linting error where log-path should be log-paths

This looks really promising and I would love to get this working

@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Jul 18, 2022
@github-actions github-actions bot changed the title please add better docs! [CY-6361] please add better docs! Jul 18, 2022
@github-actions
Copy link

Internal ticket created : CY-6361

@patrickbland patrickbland changed the title [CY-6361] please add better docs! [CY-6361] version not updating & please add better docs! Jul 18, 2022
@james-arawhanui
Copy link

james-arawhanui commented Oct 6, 2022

I also got tripped up on log-paths when the examples were log-path

I can't seem to grasp how previous version gets detected, I think I might need to apply a tag to the commit, so that next time the workflow runs it may see previous tags.

EDIT: as I suspected, the commit needs tagging for git-version to pick it up on the next run
#58 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

2 participants