Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS-607] Improvement - Check for identifiers since last tag #90

Open
zyexal opened this issue Oct 5, 2023 · 1 comment
Open

[TS-607] Improvement - Check for identifiers since last tag #90

zyexal opened this issue Oct 5, 2023 · 1 comment
Labels
jira-issue Issue tracked on JIRA

Comments

@zyexal
Copy link

zyexal commented Oct 5, 2023

Currently the minor-identifier or major-identifier is needed on the latest commit message to have any effect.

Scenario - Project with version 1.0.2:

  • User is creating many commits on a branch
    • minor changes, improvements etc. with simple commit messages and
    • a new feature with commit message containing minor-identifier (used as minor version increase identifier)
    • also publishes/deploys snapshots to repo
  • User creates a PR, but misses to add minor-identifier to the PR title

Outcome:

  • Snapshot with version 1.1.0 as we had a commit message with minor-identifier
  • Published 1.0.3 as minor-identifier was missing in the PR title

Improvement possible:

  • Let user decide if a missing identifier shall
    • break the workflow exceptionally,
    • increase versions based on commit and PR title (latest commit) or
    • ignore older commit messages (current behaviour)
  • Needs possibility to check all commits since the last tagged for minor-identifier or major-identifier
@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Oct 5, 2023
@github-actions github-actions bot changed the title Improvement - Check for identifiers since last tag [TS-607] Improvement - Check for identifiers since last tag Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Internal ticket created : TS-607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

1 participant