Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dockerfile.celery #1511

Closed
Didayolo opened this issue Jul 4, 2024 · 2 comments · Fixed by #1518
Closed

Remove Dockerfile.celery #1511

Didayolo opened this issue Jul 4, 2024 · 2 comments · Fixed by #1518
Labels
Discussion Needs to be discussed before we can come up with specifications and begin the issue Post-it Internal ideas

Comments

@Didayolo
Copy link
Member

Didayolo commented Jul 4, 2024

In #1416, the configuration was changed to use Poetry.

The file Dockerfile.celery was not updated. However, it seems that it is never used in the project.

@bbearce Any comment on this?
@Didayolo Didayolo added Discussion Needs to be discussed before we can come up with specifications and begin the issue Post-it Internal ideas labels Jul 4, 2024
@ObadaS
Copy link
Collaborator

ObadaS commented Jul 4, 2024 •
edited
Loading

Looking through both Dockerfile and Dockerfile.celery as well as docker-compose.yml, I am pretty sure that Dockerfile is the new Dockerfile.celery. I am guessing that Dockerfile.celery is simply a vestige that was never deleted.

@Didayolo
Copy link
Member Author

Didayolo commented Jul 9, 2024 •
edited
Loading

And what about Dockerfile.builder ?

https://github.com/codalab/codabench/blob/develop/Dockerfile.builder

Never mind, I see it is used by docker-compose.yml

@Didayolo Didayolo mentioned this issue Jul 9, 2024
Merged
@Didayolo Didayolo linked a pull request Jul 9, 2024 that will close this issue
Remove Dockerfile.celery #1518
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Needs to be discussed before we can come up with specifications and begin the issue Post-it Internal ideas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Dockerfile.celery codalab/codabench
2 participants
@Didayolo @ObadaS