Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request to change "default" theme function. #2142

Closed
ignat980 opened this issue Apr 1, 2024 · 2 comments
Closed

Feature request to change "default" theme function. #2142

ignat980 opened this issue Apr 1, 2024 · 2 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ignat980
Copy link

ignat980 commented Apr 1, 2024

PROBLEM:
I have custom theming in another extension that relies on the dark Youtube styling, and ImproveTube seems to overwrite the YouTube theme setting to "Device" when "default" ImproveTube theme is selected. This is especially noticeable when switching between accounts with different YouTube theme settings.

SOLUTION:
Replace "default" with a switch that disables ImproveTube theming overwrites.

ALTERNATIVES:
Change "default" ImproveTube theme setting to keep whatever setting is set in the YouTube theme options (Device, Dark, or Light), instead of always setting it to "Device".

RELEVANCE / SCOPE:
This would be good for users that like YouTube's default styling or want to have even more control over their YouTube CSS via another extension, so for both hyper-casual users and super-users. This change would also be more transparent in what the "default" setting was intended for - the setting in YouTube, not ImproveTube Light theme.

"SIDE EFFECTS":
No side effects I can think of, should be just a straightforward improvement.

CONTEXT:
What happens when "default" is selected and Device (Light) theme is forcefully selected by ImproveTube:

Screen Shot 2024-04-01 at 5 21 07 PM

VS

No extension, custom theme functional on top of Dark theme:

Screen Shot 2024-04-01 at 5 24 13 PM

Thank you!

SHORT Table (Summary)
Problem ImproveTube "default" theme is not default
Solution ImproveTube on/off switch for theme changes
Alternatives ImproveTube "default" theme to use YouTube setting, not overwrite to Device theme
Scope All users, but mostly hyper-casual-users and super-users
Side effects None
Context See screenshots
@ignat980 ignat980 added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Apr 1, 2024
@raszpl
Copy link
Contributor

raszpl commented Apr 1, 2024

its a bug #2138

@ImprovedTube
Copy link
Member

hi and thanks @ignat980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants